What I did today:
- I worked with Mark to figure out what would be the best solution for my proposed pull request for why empty details were showing when you would click on the source. We found that because the list of sources was having to reload/sync, in between the time the sync started and finished, if the user clicked on a source link, it would show up blank. We concluded that the best solution would be to just throw away the click and let the spinner spin as per usual.
- I was able to work also with Alan to figure out a very obscure bug with the History list (the list of persons you have visited recently). What was happening was: say you had a full, complete, synced history list, but then you turned on airplane mode, then tried to refresh that list; it would show up blank, other than your own record. I looked over the code where I suspected was causing the problem, but I couldn’t make any conclusions as to how it was returning a list of one person, instead of what was already in the cache! After some debugging with Alan, we were able to find out that the previous programmer (who wrote it) had made assumptions in one part of his code that this one method would always return a list, never null. But then everywhere else, he assumed just the opposite: always check for null. So there was one place where he had a single if statement where if the list was null it would do a certain operation. However, there was no else statement, so it could never get into that if statement! Anyway, we got it figured out.
Highlights:
- Quentin (my brother) called and proposed that I should make an app for him. I walked him through how time consuming that would be and tried to convince him to consider other options. We decided that a web app would be much more feasible and an overall better option for him.